core: implement EIP-8037, state creation gas cost increase#33601
Open
MariusVanDerWijden wants to merge 9 commits into
Open
core: implement EIP-8037, state creation gas cost increase#33601MariusVanDerWijden wants to merge 9 commits into
MariusVanDerWijden wants to merge 9 commits into
Conversation
MariusVanDerWijden
force-pushed
the
eip-8037
branch
from
f130451 to
ac0edb7
Compare
MariusVanDerWijden
requested review from
fjl,
gballet,
lightclient,
rjl493456442,
s1na and
zsfelfoldi
as code owners
Closed
MariusVanDerWijden
force-pushed
the
eip-8037
branch
4 times, most recently
from
89179ad to
15b3ac5
Compare
jwasinger
reviewed
Mar 7, 2026
jwasinger
reviewed
Mar 7, 2026
MariusVanDerWijden
force-pushed
the
eip-8037
branch
from
9222e0a to
c570357
Compare
MariusVanDerWijden
force-pushed
the
eip-8037
branch
3 times, most recently
from
54243de to
fb6a02a
Compare
jwasinger
reviewed
Mar 30, 2026
jwasinger
reviewed
Apr 1, 2026
jwasinger
reviewed
Apr 1, 2026
rjl493456442
reviewed
Apr 8, 2026
| return GasCosts{}, ErrGasUintOverflow | ||
| } | ||
| return totalCost, nil | ||
| return GasCosts{RegularGas: totalCost}, nil |
Member
There was a problem hiding this comment.
We should return the stateGas explicitly in the return and add the pre-deducted value back?
Member
Author
There was a problem hiding this comment.
I think there was a reason why I did it this way. The ordering when we charge state gas and when we charge regular gas matters
rjl493456442
reviewed
Apr 8, 2026
| // the necessary steps to create accounts and reverses the state in case of an | ||
| // execution error or failed value transfer. | ||
| func (evm *EVM) Call(caller common.Address, addr common.Address, input []byte, gas uint64, value *uint256.Int) (ret []byte, leftOverGas uint64, err error) { | ||
| func (evm *EVM) Call(caller common.Address, addr common.Address, input []byte, gas GasCosts, value *uint256.Int) (ret []byte, leftOverGas GasCosts, gasUsed GasUsed, err error) { |
Member
There was a problem hiding this comment.
Nitpick, It will be much more readable if:
(1) change gas to gasBudget
(2) change leftOverGas to gasBudget
and I am wondering if it's feasible/makesense to change to gasBudget as the pointer, so that the leftOverGas can be eliminated.
Member
Author
There was a problem hiding this comment.
I tried it, but its not great. Neither for readability nor useability
I would prefer not to do it
Member
There was a problem hiding this comment.
Is the gasBudget idea bad for readability or the pointer idea is bad, or both of them :)
rjl493456442
reviewed
Apr 8, 2026
rjl493456442
reviewed
Apr 8, 2026
rjl493456442
reviewed
Apr 8, 2026
MariusVanDerWijden
force-pushed
the
eip-8037
branch
from
e5c644d to
fc42a77
Compare
MariusVanDerWijden
force-pushed
the
eip-8037
branch
from
fc42a77 to
84cbc04
Compare
| if subGasAmount > cost.StateGas { | ||
| subGasAmount -= cost.StateGas | ||
| } else { | ||
| subGasAmount = 0 |
| // exceeded the intrinsic-charged state gas | ||
| txState := cost.StateGas | ||
| if execGasUsed.StateGas > 0 { | ||
| txState += uint64(execGasUsed.StateGas) |
Member
Author
There was a problem hiding this comment.
Can we go lower than intrinsic gas here? We should theoretically do that. Check spec
Comment on lines
+676
to
+678
| if !contract.IsSystemCall { | ||
| stateGas = params.StorageCreationSize * evm.Context.CostPerGasByte | ||
| } |
jwasinger
reviewed
May 6, 2026
MariusVanDerWijden
force-pushed
the
eip-8037
branch
from
84cbc04 to
4c3abb8
Compare
| if evm.chainRules.IsEIP150 { | ||
| gas = params.SelfdestructGasEIP150 | ||
| var address = common.Address(stack.back(0).Bytes20()) | ||
| if gas > contract.Gas.RegularGas { |
Member
There was a problem hiding this comment.
@MariusVanDerWijden why do we need to abort the gas calculation with a nil error here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements https://eips.ethereum.org/EIPS/eip-8037
mainly done in order to judge the complexity of the EIP
and to act as a jumping off point, since the eip will likely
change.